Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Node.js 10 #32

Merged
merged 5 commits into from
Nov 5, 2020
Merged

Require Node.js 10 #32

merged 5 commits into from
Nov 5, 2020

Conversation

realityking
Copy link
Contributor

I'm not sure if you're happy with the change I've made to how semver is used. Please let me know if you want that changed back to the satisfies function.

@realityking
Copy link
Contributor Author

xo is failing because of the helper/util.js file being imported in the tests. How do you want to handle that?

@sindresorhus sindresorhus changed the title Require Node 10 Require Node.js 10 Nov 5, 2020
@sindresorhus sindresorhus merged commit 064e92d into sindresorhus:master Nov 5, 2020
@sindresorhus
Copy link
Owner

Thanks. I'll handle the thing. I don't plan to release this yet though as it's not worth doing a breaking change just for this. Also, for users that can target Node.js 10, they can just use the native option.

@realityking realityking deleted the node-10 branch November 5, 2020 21:44
@realityking
Copy link
Contributor Author

Well not those packages that supper Node >=10<10.12 but I understand that the semver bump is not worth the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants