add number of reversions option #3
Conversation
stevemao
force-pushed
the
number-of-reversions
branch
from
26a3bbd to
7dadbdb
Compare
| return through.obj(function (file, enc, cb) { | ||
| var history = file.history; | ||
|
|
||
| if (history.length > 1) { | ||
| if (history.length > reversions) { |
There was a problem hiding this comment.
I don't think it should just silently not do its thing when there aren't enough history. Either throw or reverse as much as possible. Not sure which.
There was a problem hiding this comment.
reverse as much as possible? Since it's backward compatible any no one raised a request on throwing an error before.
There was a problem hiding this comment.
Done. I think it makes more sense now
There was a problem hiding this comment.
reverse as much as possible?
👍
stevemao
force-pushed
the
number-of-reversions
branch
from
7dadbdb to
0189276
Compare
|
gulpjs/vinyl-fs#77 is merged and the added tests gulpjs/vinyl-fs#79 passed. We could use double |
👍 |
| @@ -1,15 +1,19 @@ | |||
| 'use strict'; | |||
| var through = require('through2'); | |||
|
|
|||
| module.exports = function () { | |||
| module.exports = function (reversions) { | |||
| reversions = reversions || 1; | |||
There was a problem hiding this comment.
reversions = typeof reversions === 'number' ? reversions : 1; as users might want to explicitly pass in 0 for some reason.
There was a problem hiding this comment.
should also have an empty line below this.
stevemao
force-pushed
the
number-of-reversions
branch
from
04f7513 to
295e33a
Compare
|
double dest example needs to wait until |
|
Looks good. Thanks :) |
Ref: sindresorhus/vinyl-paths#2
Only thing is its probably not the best use-case to demonstrate in the README.md. However I can't use double
destbecause thebasewould change in after the firstdest(). gulpjs/vinyl-fs#77