Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HTTP/1 and HTTP/2 timings tests #1957

Merged
merged 3 commits into from
Jan 5, 2022
Merged

Add HTTP/1 and HTTP/2 timings tests #1957

merged 3 commits into from
Jan 5, 2022

Conversation

etnbrd
Copy link
Contributor

@etnbrd etnbrd commented Jan 4, 2022

This PR implements tests to make sure the timings and timings.phases values are not missing in both http/1 and http/2.
It is currently failing for an http/2 request.

Checklist

  • I have read the documentation.
  • I have included a pull request description of my changes.
  • I have included some tests.
  • If it's a new feature, I have included documentation updates in both the README and the types.

@etnbrd etnbrd mentioned this pull request Jan 4, 2022
Open
2 tasks
szmarczak
szmarczak reviewed Jan 4, 2022
View reviewed changes
test/timings.ts Outdated Show resolved Hide resolved
@szmarczak szmarczak changed the title Add http/1 and http/2 timings tests Add HTTP/1 and HTTP/2 timings tests Jan 5, 2022
@szmarczak szmarczak merged commit 236e744 into sindresorhus:main Jan 5, 2022
@szmarczak
Copy link
Collaborator

Thanks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szmarczak szmarczak szmarczak left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@etnbrd @szmarczak @sindresorhus