Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove parse-json dependency #134

Closed
floatdrop opened this issue Nov 20, 2015 · 2 comments
Closed

Remove parse-json dependency #134

floatdrop opened this issue Nov 20, 2015 · 2 comments
Milestone
6.0.0

Comments

@floatdrop
Copy link
Contributor

I'm not 100% sure that this is possible, but depending on two versions of same thing is not ok either.

//cc @Qix-
@floatdrop floatdrop added this to the 6.0.0 milestone Nov 20, 2015
@sindresorhus
Copy link
Owner

@floatdrop I think we should just drop parse-json. I don't think it's worth its size (100kb) in this case.

@floatdrop
Copy link
Contributor Author

@sindresorhus that's one way. I found it very useful on wrong backends responses - if we decide to drop it - first line of broken input should stay in error message.

floatdrop added a commit that referenced this issue Nov 20, 2015
@floatdrop
remove parse-json
e7e8719 
Closes #134
@floatdrop floatdrop changed the title Replace create-error-class with error-ex Remove parse-json dependency Nov 28, 2015
floatdrop added a commit that referenced this issue Dec 2, 2015
@floatdrop
remove parse-json
4d6e03c 
Closes #134
floatdrop added a commit that referenced this issue Dec 2, 2015
@floatdrop
remove parse-json
95b4f8c 
Closes #134
@floatdrop floatdrop mentioned this issue Dec 2, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
2 participants
@sindresorhus @floatdrop