Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dev tools to update browser variables list. #165

Closed
wants to merge 11 commits into from
Closed

Improve dev tools to update browser variables list. #165

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0924a14
add global with get-browser-globals.js script (resolves #164)
Jul 5, 2020
3c74fce
fix get-browser-globals.js script to pass the alphabetical order test…
Jul 5, 2020
64a645b
change the way it gets browsers globals variables with get-browser-gl…
Jul 6, 2020
aad6d7a
automate update browsers default scope [wip] #164 #166
Jul 6, 2020
f32d182
update docs how to update the browsers score [WIP] #164 #166
Jul 6, 2020
86b7c9f
some adds to the get-jshint-browser script and fix readme
Jul 6, 2020
0416765
leave globals.json as it was
Jul 6, 2020
214f522
fix #166 issue again
Jul 6, 2020
6d26f17
update/get-browser-globals/combine.js WIP #166
Jul 6, 2020
61febb9
finish npm run combine-browser script first version and update global…
Jul 6, 2020
f1e0a90
add xo ignores for the update scripts
Jul 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
node_modules
yarn.lock
browser_vars.json
22 changes: 12 additions & 10 deletions get-browser-globals.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
'use strict';

const fs = require('fs');

const { browser } = require('jshint/src/vars.js');


const blacklist = [
/^webkit/i,
'BeforeInstallPromptEvent',
Expand Down Expand Up @@ -42,8 +47,8 @@ const blacklist = [
'values'
];

const globals = Object.getOwnPropertyNames(window)
.sort((a, b) => a.toLowerCase().localeCompare(b.toLowerCase()))
const globals = Object.getOwnPropertyNames(browser)
.sort((a, b) => a.localeCompare(b))
.filter(global => {
for (const pattern of blacklist) {
if (typeof pattern === 'string') {
Expand All @@ -65,11 +70,8 @@ for (const key of globals) {
ret[key] = key.startsWith('on');
}

copy(JSON.stringify(ret, null, '\t'));

/*

Usage:
Open an Incognito window in Chrome Canary and paste the above into the console. You'll now have a new object in your clipboard for the `browser` field in `globals.json`. You still need to manually filter out items from the `builtin` list.

*/
fs.writeFile('./browser_vars.json', JSON.stringify(ret, null, '\t'), (error) => {
if (error) {
return console.log(error);
}
});
Loading