Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Found 17 global variables with my module. #164

Closed
shapkarin opened this issue Jul 5, 2020 · 4 comments
Closed

Found 17 global variables with my module. #164

shapkarin opened this issue Jul 5, 2020 · 4 comments

Comments

@shapkarin
Copy link

Hello. I want to use your package for my one. Not sure if that is not exist already. But anyway.
The problem that when I start to test my package I found 17 global vars in the chrome incognito mode.
Here is the list:

0: "onformdata"
1: "onwebkitanimationend"
2: "onwebkitanimationiteration"
3: "onwebkitanimationstart"
4: "onwebkittransitionend"
5: "onselectstart"
6: "onselectionchange"
7: "captureEvents"
8: "releaseEvents"
9: "webkitRequestAnimationFrame"
10: "webkitCancelAnimationFrame"
11: "webkitStorageInfo"
12: "chrome"
13: "onpointerrawupdate"
14: "webkitRequestFileSystem"
15: "webkitResolveLocalFileSystemURL"
16: "trustedTypes"

I forked your repo and want to add them if they all are the default now for Chrome too.

@shapkarin
Copy link
Author

I will try to provide a PR

@shapkarin
Copy link
Author

I opened PR. But that a little bit strange that with yours plugin I got more global variables than 14 at issue #164 maybe it's some bug in my code as well. But I hope that I help you yo update your list with that PR in any case.

@shapkarin
Copy link
Author

shapkarin commented Jul 6, 2020

some of they are in a black list. but maybe some other should be added too like onpointerrawupdate. anyway I helped community to automate that browsers global variables part. Maybe that will helps.

@sindresorhus
Copy link
Owner

We now automatically generate the globals, so this should no longer be a concern.

shapkarin pushed a commit to shapkarin/diff-browser-globals that referenced this issue Jun 18, 2024
shapkarin pushed a commit to shapkarin/diff-browser-globals that referenced this issue Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants