Fix wrong length computation

sindresorhus · Aug 10, 2023 · 35327d0 · 35327d0
1 parent 558b93a
commit 35327d0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/index.js b/index.js
@@ -39,12 +39,13 @@ const getStreamContents = async (stream, {convertChunk, getSize, getContents}, {
 		for await (const chunk of stream) {
 			const chunkType = getChunkType(chunk);
 			const convertedChunk = convertChunk[chunkType](chunk, textDecoder);
-			length += getSize(convertedChunk);
+			const chunkSize = getSize(convertedChunk);
 
-			if (length > maxBuffer) {
+			if (length + chunkSize > maxBuffer) {
 				throw new MaxBufferError();
 			}
 
+			length += chunkSize;
 			chunks.push(convertedChunk);
 		}
 

diff --git a/test.js b/test.js
@@ -211,8 +211,8 @@ test('maxBuffer unit is each array element with getStreamAsArray()', checkMaxBuf
 
 test('set error.bufferedData when `maxBuffer` is hit', async t => {
 	const maxBuffer = fixtureLength - 1;
-	const {bufferedData} = await t.throwsAsync(setup([...fixtureString], {maxBuffer}), {instanceOf: MaxBufferError});
-	t.true(fixtureString.startsWith(bufferedData));
+	const {bufferedData} = await t.throwsAsync(setupBuffer([...fixtureString], {maxBuffer}), {instanceOf: MaxBufferError});
+	t.true(fixtureString.startsWith(bufferedData.toString()));
 	t.true(bufferedData.length <= maxBuffer);
 });