Document stream() detection limitation
#434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
reviewed
Feb 7, 2021
|
Could we maybe let the user decide how big of a sample they want? That way they could decide whether they favor performance or accuracy. |
Closed
Borewit
force-pushed
the
document-stream-limitation
branch
from
3e67451
to
d3b2543
Compare
sindresorhus
changed the title
stream() detection limitation
|
I should actually put a bit of unit testing in place, with an exemplary pointing out (& testing one) with a different sample size. |
Suppress the End-Of-Stream, instead assign `undefined` to `stream.fileType`. Fix: #467
Borewit
force-pushed
the
document-stream-limitation
branch
from
8657114
to
0b84897
Compare
Borewit
force-pushed
the
document-stream-limitation
branch
from
0b84897
to
c635507
Compare
sindresorhus
requested changes
Jul 22, 2021
Borewit
force-pushed
the
document-stream-limitation
branch
from
8dc4c7d
to
f68ae1b
Compare
|
Note that the example provided for |
Borewit
force-pushed
the
document-stream-limitation
branch
from
f68ae1b
to
2a26e42
Compare
|
Not done: #434 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
stream()limitation.stream()configurable, and add corresponding unit testsIncludes PR: #468 (better to merge that one first)