Improve bullet figure

[ehmicky]

The bullet figure U-25cf ● displays correctly on Windows, is there a reason to use * instead?

Ubuntu 20.10 Gnome terminal:

Windows 10 cmd.exe (CP850):

[sindresorhus]

It definitely did not display correctly when I made this package. The problem with cmd is that it might support such characters if you have the correct font installed, from what I can remember. I assume you're not testing on a fresh WIndows 10 installation, so your result may or may not be representable.

Some more info: https://stackoverflow.com/questions/388490/how-to-use-unicode-characters-in-windows-command-line

Another possibility, this was fixed in Node.js or rather libuv, by switching from File I/O to Console I/O, or something.

[ehmicky]

I am using a fresh Windows 10 installation in VirtualBox, specifically 10.0.17763. I am keeping it fresh and not installing anything (including fonts, but also any other software), for testing purpose.

Note: I ran cmd /k chcp to confirm the code page was 850.

It seems like the character displays correctly as far as at least Node 0.10, so I would assume this might not be related to Node.js nor libuv:

I am wondering whether the difference you experienced might due to an improvement of the default cmd.exe font in a Windows 10 patch release? If this is the case, would it be fair to assume Windows 10 users would have this patch release, considering Windows updates automatically (or gives constant reminders about it)?

[sindresorhus]

I am wondering whether the difference you experienced might due to an improvement of the default cmd.exe font in a Windows 10 patch release? If this is the case, would it be fair to assume Windows 10 users would have this patch release, considering Windows updates automatically (or gives constant reminders about it)?

That is the most likely scenario, yes.

[sindresorhus]

Can you do like

figures/index.js

Line 22 in fba7e78

bullet: '●',

? It makes it easier to read the code as you can easily see that they're the same.

[ehmicky]

Did you mean using the following?

	bullet: main.bullet,

If so, I can do this 👍

I can also update it in the other PRs.

Also, I can submit an additional PR to use this pattern for all existing characters that are common in main and windows. At the moment, there are still a few which are identical but do not use this pattern (for example line).

[sindresorhus]

Yeah, that's what I meant. I must have copied the wrong URL.

[sindresorhus]

Also, I can submit an additional PR to use this pattern for all existing characters that are common in main and windows

Sure. I think one PR for all those changes is best.

[ehmicky]

Fixed!

It turns out line was the only figure not using this pattern. I submitted a PR at #44
I also fixed all the current PRs not using this pattern 👍