Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error.timedOut not working with execa.sync() #249

Merged
merged 2 commits into from
May 14, 2019
Merged

Fix error.timedOut not working with execa.sync() #249

merged 2 commits into from
May 14, 2019

Conversation

ehmicky
Copy link
Collaborator

@ehmicky ehmicky commented May 14, 2019 •
edited
Loading

When execa.sync() times out because of the timeout option, error.timedOut is still false.

This PR fixes this.

@ehmicky ehmicky force-pushed the feature/fix-timedout-sync branch from 8ed364d to c3857e9 Compare May 14, 2019 17:27
sindresorhus
sindresorhus reviewed May 14, 2019
View reviewed changes
test.js Outdated Show resolved Hide resolved
@ehmicky
Copy link
Collaborator Author

ehmicky commented May 14, 2019

Fixed.

@sindresorhus sindresorhus merged commit 21c706a into master May 14, 2019
@sindresorhus sindresorhus deleted the feature/fix-timedout-sync branch May 14, 2019 18:47
@ehmicky ehmicky mentioned this pull request May 15, 2019
Closed
@dependabot dependabot bot mentioned this pull request Mar 14, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehmicky @sindresorhus