Remove compatibility layer for util.getSystemErrorName()
#221
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the Node.js documentation says that
util.getSystemErrorName()
is added in9.7.0
, it's actually been back-ported 6 months later to8.12.0
. I tried it withnvm
and confirm this function works in8.12.0
.We use a compatibility layer for this function, which can now be removed.
I am a little unclear whether we support
8.0.0
to8.11.0
, or only the later8.*.*
versions:package.json
engines.node
field shows>=8
, which is translated bynpm
to>=8.0.0
(usingsemver
under the hood).8
, which is translated to the latest8.16.0
(usingnvm
under the hood).(I think those two should be in sync, but that's a separate issue).
As a side effect, this would also fix test coverage there.