Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add execa.all() #192

Closed
wants to merge 1 commit into from
Closed

Add execa.all() #192

wants to merge 1 commit into from

Conversation

ehmicky
Copy link
Collaborator

@ehmicky ehmicky commented Mar 11, 2019

This is a follow up on #171 by @tomsotte.

options.all was added but we forgot to also add execa.all().

@sindresorhus
Copy link
Owner

No, it was intentional: #171 (comment)

@ehmicky
Copy link
Collaborator Author

ehmicky commented Mar 11, 2019

Oh sorry did not see that one before.

Should execa.stdout() and execa.stderr() be deprecated?

@ehmicky ehmicky closed this Mar 11, 2019
@ehmicky ehmicky deleted the feature/all-v2 branch March 11, 2019 11:05
@sindresorhus
Copy link
Owner

Should execa.stdout() and execa.stderr() be deprecated?

No, I don't think it's worth doing that. They've been in execa for too long and is too widely used for it to be worth it to deprecate. We could add a note in the docs that destructuring would be better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehmicky @sindresorhus