Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

escape-case: Fix missing characters #678

Merged
merged 4 commits into from
Apr 10, 2020
Merged

escape-case: Fix missing characters #678

merged 4 commits into from
Apr 10, 2020

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Apr 10, 2020 •
edited
Loading

  • Fix missing characters
  • Simplify logic
  • Remove \ca from TemplateElement, should only work in regex
  • More tests

Fixes #677

@fisker fisker force-pushed the issue-677 branch 3 times, most recently from b71283a to d6dc805 Compare April 10, 2020 05:04
@fisker fisker marked this pull request as ready for review April 10, 2020 05:07
@fisker fisker mentioned this pull request Apr 10, 2020
Closed
@sindresorhus sindresorhus merged commit d986427 into sindresorhus:master Apr 10, 2020
@fisker fisker deleted the issue-677 branch April 10, 2020 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

escape-case only catches first escape sequence in string
2 participants
@fisker @sindresorhus