prefer-spread: Insert semicolon if needed
#578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
reviewed
Mar 5, 2020
| const sourceCode = context.getSourceCode(); | ||
| const getSource = node => sourceCode.getText(node); | ||
|
|
||
| const needsSemicolon = node => { |
There was a problem hiding this comment.
I tried to make a better util function for this, but seems need handle differently in different case.I don't think current implementation can use in other rule, at least not yet.
There was a problem hiding this comment.
Ok. Just something to keep in mind in case we need it in multiple places.
|
Not important, but why the last commit shows by you ? The |
|
Yes, GitHub bug. I experienced it on another repo earlier too... |
|
Can you report it? I’m AFK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sure there is still other case not handled, but should good enough for #254
Fix #254