Add isShadowed check to new-for-builtins
#540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/new-for-builtins.js
Outdated
| 'Uint16Array', | ||
| 'Uint32Array', | ||
| 'Uint8ClampedArray' | ||
| ]; |
There was a problem hiding this comment.
These are just redefinitions of what's in the rule. I think it would be better to move these to util.js and import them both in the rule and here.
test/new-for-builtins.js
Outdated
| @@ -5,6 +5,14 @@ import rule from '../rules/new-for-builtins'; | |||
| const ruleTester = avaRuleTester(test, { | |||
| env: { | |||
| es6: true | |||
There was a problem hiding this comment.
Let's start using es2020 for these instead of es6.
# Conflicts: # rules/new-for-builtins.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #122
I just steal this function from https://github.com/eslint/eslint/blob/1ee6b6388305a8671c8d4c3cf30c2dbf18a1ff7e/lib/rules/no-alert.js#L48
I've tried to solve this issue before, but failed, this function use range check instead of name check is great idea.
We may need add this check in more rules, I'll check later.
IssueHunt Summary
Referenced issues
This pull request has been submitted to:
new-for-builtinsruleIssueHunt has been backed by the following sponsors. Become a sponsor