Nested

sindresorhus · Mar 11, 2020 · 0f5277e · 0f5277e
1 parent d03cde0
commit 0f5277e
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/rules/consistent-function-scoping.js b/rules/consistent-function-scoping.js
@@ -75,9 +75,16 @@ function checkReferences(scope, parent, scopeManager) {
 		);
 }
 
+const isArrowFunctionWithThis = scope =>
+	scope.type === 'function' &&
+	scope.block &&
+	scope.block.type === 'ArrowFunctionExpression' &&
+	scope.thisFound
+
 function checkNode(node, scopeManager) {
 	const scope = scopeManager.acquire(node);
-	if (!scope || (node.type === 'ArrowFunctionExpression' && scope.thisFound)) {
+
+	if (!scope || isArrowFunctionWithThis(scope) || scope.childScopes.some(scope => isArrowFunctionWithThis(scope))) {
 		return true;
 	}
 

diff --git a/test/consistent-function-scoping.js b/test/consistent-function-scoping.js
@@ -198,6 +198,12 @@ ruleTester.run('consistent-function-scoping', rule, {
 				return doBar();
 			};
 		`,
+		outdent`
+			function doFoo(Foo) {
+				const doBar = () => () => this;
+				return doBar();
+			};
+		`,
 		// `arguments`
 		outdent`
 			function doFoo(Foo) {
@@ -343,6 +349,15 @@ ruleTester.run('consistent-function-scoping', rule, {
 			`,
 			errors: [arrowError]
 		},
+		{
+			code: outdent`
+				function doFoo(Foo) {
+					const doBar = () => (function() {return () => this})();
+					return doBar();
+				};
+			`,
+			errors: [arrowError]
+		},
 		// `arguments`
 		{
 			code: outdent`