Handle Bluebird unhandledrejection #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bluebird.js promises don't have event.reason, they instead have event.detail.reason. An unhanded rejection from bb causes an exception from your plugin. Given Bluebird's popularity it's probably worthwhile handing this case at least until they fix their side. As you can see they've taken a couple of kicks at this already. Links to their issues: petkaantonov/bluebird#1447 petkaantonov/bluebird#1509
nmccready
reviewed
Apr 23, 2018
| @@ -72,7 +72,7 @@ module.exports = options => { | |||
| }, 200); | |||
| window.addEventListener('unhandledrejection', event => { | |||
| event.preventDefault(); | |||
| rejectionHandler(event.reason); | |||
| rejectionHandler(event.reason || event.detail.reason); | |||
There was a problem hiding this comment.
Instead of covering all the possible unique cases of different event.reasons should this not become an option? IE do something like this?
options.eventReasonPath = ['reason']; // default
rejectionHandler(get(event, options.eventReasonPath)) ??
There was a problem hiding this comment.
No, libraries should just follow the standard.
|
I appreciate the PR, but I'm not interested in adding this. Bluebird should follow the Promise spec. Adding support for weird behavior in custom Promise libraries is a slippery slope. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bluebird.js promises don't have event.reason, they instead have event.detail.reason. An unhanded rejection from bb causes an exception from your plugin. Given Bluebird's popularity it's probably worthwhile handing this case at least until they fix their side. As you can see they've taken a couple of kicks at this already. Links to their issues:
petkaantonov/bluebird#1447
petkaantonov/bluebird#1509