Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add built-in support for spellchecking #94

Merged
merged 16 commits into from
Apr 14, 2020
Merged

Add built-in support for spellchecking #94

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
a0ca442
Feature:Builtin support for spellcheck suggestions
nautatva Feb 5, 2020
b6d9854
linting errors
nautatva Feb 5, 2020
4ffb76a
SearchWithGoogle,AutoCorrection,learnSpell support
nautatva Feb 14, 2020
57c9515
extra space removed
nautatva Feb 14, 2020
4efc985
better nomenclature
nautatva Feb 14, 2020
1e6fe1e
Refactored code
nautatva Feb 24, 2020
f4ebfdd
Docs updated to be in sync
nautatva Mar 10, 2020
085c304
Encoding the URLqueryparams
nautatva Mar 11, 2020
8e77f66
Update package.json
sindresorhus Mar 11, 2020
fc8f059
encoding the search parameter
nautatva Mar 11, 2020
66afb4d
Update readme.md
sindresorhus Apr 6, 2020
36899d7
Update index.d.ts
sindresorhus Apr 6, 2020
6b867d6
Update index.d.ts
sindresorhus Apr 6, 2020
4160cda
Update readme.md
sindresorhus Apr 6, 2020
f27ffa7
Arranged in same order as they appear in menu.
nautatva Apr 7, 2020
4a4ebb2
Update index.d.ts
sindresorhus Apr 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion fixture-menu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,10 @@ contextMenu({
(async () => {
await app.whenReady();

await (new BrowserWindow()).loadFile(path.join(__dirname, 'fixture.html'));
await (new BrowserWindow({
webPreferences: {
nodeIntegration: true,
spellcheck: true
}
})).loadFile(path.join(__dirname, 'fixture.html'));
})();
5 changes: 3 additions & 2 deletions fixture.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ contextMenu({
type: 'separator'
}
],
append: () => {},
append: () => { },
showCopyImageAddress: true,
showSaveImageAs: true,
showInspectElement: false
Expand All @@ -45,7 +45,8 @@ contextMenu({

await (new BrowserWindow({
webPreferences: {
nodeIntegration: true
nodeIntegration: true,
spellcheck: true
}
})).loadFile(path.join(__dirname, 'fixture.html'));
})();
3 changes: 2 additions & 1 deletion index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,8 @@ declare namespace contextMenu {
- `showSaveImageAs`
- `showInspectElement`
- `showServices`

- `dictionary`

@default [defaultActions.cut(), defaultActions.copy(), defaultActions.paste(), defaultActions.separator(), defaultActions.saveImage(), defaultActions.saveImageAs(), defaultActions.copyLink(), defaultActions.copyImage(), defaultActions.copyImageAddress(), defaultActions.separator(), defaultActions.copyLink(), defaultActions.separator(), defaultActions.inspect()]
*/
readonly menu?: (
Expand Down
17 changes: 17 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,24 @@ const create = (win, options) => {

const shouldShowInspectElement = typeof options.showInspectElement === 'boolean' ? options.showInspectElement : isDev;

const dictSuggestions = [];
for (let index = 0; index < props.dictionarySuggestions.length; index++) {
dictSuggestions.push(
{
id: 'dictSuggestions',
label: props.dictionarySuggestions[index],
visible: props.isEditable && hasText && props.misspelledWord,
click(menuItem) {
const target = webContents(win);
target.insertText(menuItem.label);
}
}
);
}

let menuTemplate = [
defaultActions.separator(),
...dictSuggestions,
defaultActions.separator(),
options.showLookUpSelection !== false && defaultActions.lookUpSelection(),
defaultActions.separator(),
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"devDependencies": {
"@types/node": "^12.0.10",
"ava": "^2.1.0",
"electron": "^7.1.1",
"electron": "^8.0.0",
"tsd": "^0.10.0",
"xo": "^0.25.3"
},
Expand All @@ -47,4 +47,4 @@
"browser"
]
}
}
}
4 changes: 3 additions & 1 deletion readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,8 @@ The following options are ignored when `menu` is used:
- `showSaveImageAs`
- `showInspectElement`
- `showServices`

- `dictionary`

Default actions:

- `separator`
Expand All @@ -200,6 +201,7 @@ Default actions:
- `copyLink`
- `inspect`
- `services`
- `dictionary`

Example:

Expand Down