Fix dragging scrollbar when app is zoomed #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitecrownclown
changed the title
CvX
requested changes
Jun 25, 2019
whitecrownclown
force-pushed
the
fix/scrollbar-on-zoom
branch
from
d326ae9 to
08f7795
Compare
CvX
approved these changes
Jun 26, 2019
sindresorhus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sindresorhus
Fixes #765
The scrollbar from the conversation list has a weird behaviour when the
zoomproperty is applied on the parent container.I could not reproduce this in a separate environment. It may be related to
electronand/ormessenger.The workaround is to apply
zoomon the content (without the scrollbar).I've also updated theconversationSelectorwith a fallback.