Add camera plug to Snap build config
#813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any other plugs we might need? https://docs.snapcraft.io/supported-interfaces/7744 |
|
Not too sure -- I'm afraid I'm a recent user and haven't read much of the code here yet. Nothing jumped out at me, though 🙂 |
sindresorhus
changed the title
camera plug to Snap build config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Camera doesn't work for me when installing from the snap store, and it looks like the reason is because it doesn't have permissions. The old workaround of
snap install --classicno longer works as of[email protected](relevant PR).Reading the relevant docs for electron-builder and snap, it seems like the right solution is to use the default confinement model and to explicitly specify a
snap.plugsthat includescamerain theelectron-builderconfig.