Add Launch at Login setting for macOS and Windows

[whitecrownclown]

@sindresorhus
Fixes #773

Hello!
I've added the following :

• Launch at login menu item
• Launch as hidden menu item (disabled if launch at login is false)
• Tested on macOS 10.14.3

Feedback is welcome, thanks!

[sindresorhus]

You shouldn’t store the states in the config store. Just fetch the actual states from the getLogin... method when needed. That way the settings don’t get out of sync.

[sindresorhus]

• Launch as hidden menu item (disabled if launch at login is false)

I don't see the point of having a setting for this. We should just launch hidden.

[whitecrownclown]

@sindresorhus I've updated the PR again.

• Added the ts definition from electron
• Removed Launch as Hidden; defaults to the same value as Launch at Login

[whitecrownclown]

@sindresorhus Updated again, however i'm unsure what you mean by this:

And openAsHidden: item.checked needs to be updated.

Do you mean to set it to true always? It is being updated with the same value as Launch at Login. I've noticed if Launch at Login is false it will not set Launch as Hidden as true, but false as well.

[sindresorhus]

Do you mean to set it to true always?

Yes, setting it to true when openAtLogin: false should have no effect, so might as well make it simpler.

[sindresorhus]

Thanks :)

[blargle-ragequit]

Why is this not on Linux?

[CvX]

@blargle-ragequit Because the Electron API doesn’t support it: https://electronjs.org/docs/api/app#appsetloginitemsettingssettings-macos-windows

Here’s an open issue at the Electron repo: electron/electron#15198