Respect "Do Not Disturb" on macOS

[whitecrownclown]

Fixes #496

• Using https://github.com/felixrieseberg/electron-notification-state to get the DND status (includes both mac DND and windows quiet hours)
• Disables bounce and messenger sound notification
• Only works on init/refresh, if status changes while the app is on, it will not update. Any clue if and how can this be done?

[sindresorhus]

• Using felixrieseberg/electron-notification-state to get the DND status

We can't use this module as it uses native Node.js add-ons, which mean we'll no longer be able to build all the binaries on one system.

• Disables bounce and messenger sound notification

Should it disable the Dock badge too?

• Only works on init/refresh, if status changes while the app is on, it will not update. Any clue if and how can this be done?

You can listen to the com.apple.notificationcenterui.dndprefs_changed distributed Apple event with https://electronjs.org/docs/api/system-preferences#systempreferencessubscribenotificationevent-callback-macos

[sindresorhus]

For macOS, you might not even need a module for this. I think you can just read the doNotDisturb key from the UserDefaults com.apple.notificationcenterui. (See Electron docs on how to read user defaults).

https://github.com/felixrieseberg/macos-notification-state/blob/07b4c6488252d45835201ce74500df8b806c5cd3/lib/do-not-disturb.mm#L4

[whitecrownclown]

@sindresorhus I've been trying to get the doNotDisturb user default using Electron's API but i'm always gettings false, which also seems to be the case for any key that doesn't exist.

systemPreferences.getUserDefault('doNotDisturb', 'boolean');

Also my attempt to get the event didn't work, not getting any callback :

systemPreferences.subscribeNotification('com.apple.notificationcenterui.dndprefs_changed', callback)

[sindresorhus]

I've been trying to get the doNotDisturb user default using Electron's API but i'm always gettings false, which also seems to be the case for any key that doesn't exist.

You're not specifying the suite name, which is not surprising, since it's not currently possible in Electron. I've opened an issue about it: electron/electron#17031

systemPreferences.subscribeNotification('com.apple.notificationcenterui.dndprefs_changed', callback)

I have no idea why this is not working though...

[sindresorhus]

Seems it would be easiest to just go with https://github.com/sindresorhus/do-not-disturb and polling for now.

Ideally, the do-not-disturb package should have a change event though: sindresorhus/do-not-disturb#6

[felixfbecker]

• Only works on init/refresh, if status changes while the app is on, it will not update. Any clue if and how can this be done?

If that's true I would rather not have this feature...

[sindresorhus]

@felixfbecker Polling is an option, or implementing sindresorhus/do-not-disturb#6.

[whitecrownclown]

@sindresorhus I can take on the polling approach. I'm not sure how to start on sindresorhus/do-not-disturb#6

[whitecrownclown]

@sindresorhus I've implemented a polling solution. Would you mind having a look over it for any feedback? Thanks!

[whitecrownclown]

Waiting on sindresorhus/do-not-disturb#8 to be merged.

[sindresorhus]

https://github.com/sindresorhus/do-not-disturb/releases/tag/v1.1.0

[sindresorhus]

Can you mention it in the readme highlights that it respects "Do Not Disturb" on macOS?

[sindresorhus]

If I have "Sounds" disabled, then turn on "Do Not Disturb" and then turn it off again, "Sounds" is then enabled. It should instead correctly revert back to the state before "Do Not Disturb".

[sindresorhus]

Dock badge shows even when "Do Not Disturb" is enabled.

[sindresorhus]

Thanks :)