Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix emoji style URL (add wildcard) #756

Merged
merged 1 commit into from
Jan 31, 2019
Merged

Fix emoji style URL (add wildcard) #756

merged 1 commit into from
Jan 31, 2019

Conversation

mikigal
Copy link
Contributor

@mikigal mikigal commented Jan 31, 2019

Today I notice that old emoji styles does not work on my second PC (on first it still works). I looks like facebook sometimes fetch emoji from other domain. I created wildcard on subdomain to fix this problem.

noxljgvrbw

@mikigal mikigal changed the title Fix emoji URL (add wildcard) Fix emoji style URL (add wildcard) Jan 31, 2019
CvX
CvX approved these changes Jan 31, 2019
View reviewed changes
Copy link
Collaborator

@CvX CvX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! 🚀

I wasn't sure if *://*.facebook.com(…) still matched e.g. https://facebook.com(…) (i.e. an URL without any subdomain), but I've tried it and it does, so all good to go! 👍

@sindresorhus sindresorhus merged commit 50590a7 into sindresorhus:master Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CvX CvX CvX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikigal @CvX @sindresorhus