Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Electron Spellchecker support #246

Closed

Conversation

archcorsair
Copy link

Looks like spell checking is working but there seems to be a bug in electron-spellchecker that causes the spelling suggestions to only appear after you click off the initial right-click popup.
Would be great if someone could have a look into this.

@sindresorhus
Copy link
Owner

From the issue thread:

Awesome :) Note: #14 (comment)

@archcorsair
Copy link
Author

@sindresorhus Travis CI is failing for reasons outside of tests/my control. Could you take a look?

@archcorsair archcorsair closed this Jul 6, 2017
@kevva
Copy link
Contributor

kevva commented Jul 6, 2017

Why did you create a new PR?

@kevva
Copy link
Contributor

kevva commented Jul 6, 2017

Could you try adding libxkbfile-devel to the APT packages in .travis.yml? That should fix the Travis issue.

@sindresorhus
Copy link
Owner

@archcorsair Please actually read my comment in #14 that I've linked to multiple times now ;)

I think it should be added to electron-context-menu though, as it's what Caprine uses for the context menu, and that way it would benefit many apps, not just Caprine.

electron-context-menu is used for other things in the app and will not be removed. The correct solution is adding Electron Spellchecker support to that module.

@archcorsair archcorsair reopened this Jul 6, 2017
@archcorsair
Copy link
Author

@sindresorhus I will see what I can do. Can you point me to where electron-context-menu is being used elsewhere?

@kevva
Copy link
Contributor

kevva commented Jul 6, 2017

Sorry, wrong distro, it should be libxkbfile-dev I think.

@sindresorhus I will see what I can do. Can you point me to where electron-context-menu is being used elsewhere?

It's used in a number of apps, see https://github.com/search?l=JavaScript&q=electron-context-menu&type=Code&utf8=%E2%9C%93.

@archcorsair
Copy link
Author

@sindresorhus @kevva I attempted to integrate spelling checking directly into electron-context-menu however this isn't possible: electron-spellchecker does not support running in the Browser process, it only allows running in the Renderer process. It uses Electron remote APIs. We cannot do this in your context menu because it runs in the browser process.

Any thoughts?

@kevva
Copy link
Contributor

kevva commented Jul 7, 2017

@archcorsair, I'll have a look at it.

@sindresorhus
Copy link
Owner

sindresorhus commented Jul 7, 2017

We cannot do this in your context menu because it runs in the browser process.

It runs in both processes. We can just take advantage of remote.require when in the browser process for importing electron-spellchecker.

@nahive
Copy link

nahive commented Jul 31, 2017

Any progress on that? I'd love to use text replacements in caprine.

@alekksander
Copy link

is it to be done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants