-
-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Electron Spellchecker support #246
Add Electron Spellchecker support #246
Conversation
From the issue thread:
|
@sindresorhus Travis CI is failing for reasons outside of tests/my control. Could you take a look? |
Why did you create a new PR? |
Could you try adding |
@archcorsair Please actually read my comment in #14 that I've linked to multiple times now ;)
|
@sindresorhus I will see what I can do. Can you point me to where |
Sorry, wrong distro, it should be
It's used in a number of apps, see https://github.com/search?l=JavaScript&q=electron-context-menu&type=Code&utf8=%E2%9C%93. |
@sindresorhus @kevva I attempted to integrate spelling checking directly into electron-context-menu however this isn't possible: Any thoughts? |
@archcorsair, I'll have a look at it. |
It runs in both processes. We can just take advantage of |
Any progress on that? I'd love to use text replacements in caprine. |
is it to be done? |
Looks like spell checking is working but there seems to be a bug in electron-spellchecker that causes the spelling suggestions to only appear after you click off the initial right-click popup.
Would be great if someone could have a look into this.