Fix Conversation Controls and Search Function #2198
Merged
+58
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The search in conversation functionality requires the right sidebar to be open. The method to select the search button is simplified to just the last button.
|
I've updated the changes from this pull request for the current Messenger interface. In my testing, some of the archive/delete behavior is messed up by the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes most of the selected conversation controls as well as the search functionality within a conversation.
The archive and delete functions need to be negative, since there are slightly different menus if a conversation is encrypted or not (usually if there's a separate encrypted conversation), but the end of the menus are the same. (Not sure why this distinction still exists...)
Already encrypted:
Can start encrypted chat:
Fixes #2185.