Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden dialog issue Fix #2108

Merged
merged 4 commits into from
Feb 18, 2024
Merged

Conversation

stkrknds
Copy link
Contributor

@stkrknds stkrknds commented Jan 12, 2024

Hello. Changed/updated some selectors in order to fix the hidden dialog issue.

Fixes #2106.
Fixes #2100(?) (not sure about the camera part)
Fixes #2098.
Fixes #2096.
Edit: Fixes #2113.

@stkrknds stkrknds mentioned this pull request Feb 3, 2024
@sgtcoder
Copy link
Contributor

sgtcoder commented Feb 3, 2024

Confirmed Messenger Settings works from the File Menu.

@giannistolou
Copy link

When will this pull request go live?

@stkrknds
Copy link
Contributor Author

When will this pull request go live?

Hi @giannistolou. I don't know exactly when. Only maintainers can merge prs.

@sgtcoder
Copy link
Contributor

Welcome to use my merged version for the time being, notifications also fixed too

https://github.com/sgtcoder/caprine/releases

@mquevill
Copy link
Collaborator

I was able to replicate all listed issues except #2106 on Linux or Mac. The changes in this PR seem to fix all of the listed issues. I would assume that it also addresses the reaction issues too.

@dusansimic dusansimic merged commit 2780be5 into sindresorhus:main Feb 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants