-
-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Caprine features on new UI #1514
Conversation
@sindresorhus, what do you think about this way of fixing things (just throwing in if statements everywhere to check if user has the new design). Other solution would be making two function for each feature (one for new design and one for old and calling them separately. That might be cleaner but it worries me that there would be a lot of duplicate code. What is your opinion on this? |
Seems ok. |
@dusansimic Maybe we should merge this now, do a release, and then you can continue the rest of the items in a new PR? Just to get the fixes out there. |
Agreed. I'm making this a regular pr and I'll start working on other issues in specific PR-s for each issue from now on. |
Fix increasing, decreasing and resetting text size.
f03ba4d
to
cf12ec7
Compare
Can you make the titlebar draggable on the new design? I don't think we can ship it before that's done as the window cannot be moved. |
Yeah, I don't have a Mac but there was already an issue open about this #1488. Does this seem fine or should we hide the profile picture and the Chats label. Since I don't have a Mac, maybe we should do the cosmetic fixes later? |
Seems fine. We can do the cosmetic fixes later. |
I've added the CSS styles from the issue I've mentioned. Please check if it works. |
Nice work! |
Show Unread Badge isn't fixed, it was for some time, but isn't working anymore. |
This is a PR for fixing all Caprine features on the new UI. All fixed features are checked in the list below.
Private mode for new Messenger UI #1492Fix private mode on new design #1559)