Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Caprine features on new UI #1514

Merged
merged 5 commits into from
Jan 25, 2021
Merged

Conversation

dusansimic
Copy link
Collaborator

@dusansimic dusansimic commented Jan 2, 2021

This is a PR for fixing all Caprine features on the new UI. All fixed features are checked in the list below.

  • File menu
    • New conversation
    • Caprine settings
      • Privacy
      • Emoji style
      • Autoplay videos
      • Show message preview in notifications (⚠ not supported by new desing)
      • Mute notifications
      • Mute call ringtone
      • Show Unread Badge
      • Spell checker
      • Hardware acceleration
      • Always on top
      • Auto hide menu bar
      • Flash Window on message
      • Show tray icon
      • Launch minimized
      • Quit on Window close
      • Custom CSS
    • Messenger settings (this is not showing all options in preferences for some odd reason, the regular way to open preferences shows all options)
    • Switch to Work Chat
    • Log Out
    • Relaunch Caprine
    • Quit
  • Edit menu
  • View menu
  • Conversation menu
    • Mute conversation
    • Hide conversation
    • Delete conversation
    • Select next conversation
    • Select previous conversation
    • Find conversation
    • Insert GIF
    • Insert Sticker
    • Insert Emoji
    • Attach files
    • Focus text input
    • Spell checker
  • Help menu

@dusansimic
Copy link
Collaborator Author

@sindresorhus, what do you think about this way of fixing things (just throwing in if statements everywhere to check if user has the new design). Other solution would be making two function for each feature (one for new design and one for old and calling them separately. That might be cleaner but it worries me that there would be a lot of duplicate code. What is your opinion on this?

@sindresorhus
Copy link
Owner

what do you think about this way of fixing things (just throwing in if statements everywhere to check if user has the new design).

Seems ok.

@sindresorhus
Copy link
Owner

@dusansimic Maybe we should merge this now, do a release, and then you can continue the rest of the items in a new PR? Just to get the fixes out there.

@dusansimic
Copy link
Collaborator Author

@dusansimic Maybe we should merge this now, do a release, and then you can continue the rest of the items in a new PR? Just to get the fixes out there.

Agreed. I'm making this a regular pr and I'll start working on other issues in specific PR-s for each issue from now on.

@dusansimic dusansimic marked this pull request as ready for review January 19, 2021 12:32
@sindresorhus
Copy link
Owner

Can you make the titlebar draggable on the new design? I don't think we can ship it before that's done as the window cannot be moved.

@dusansimic
Copy link
Collaborator Author

Yeah, I don't have a Mac but there was already an issue open about this #1488. Does this seem fine or should we hide the profile picture and the Chats label. Since I don't have a Mac, maybe we should do the cosmetic fixes later?

@sindresorhus
Copy link
Owner

sindresorhus commented Jan 22, 2021

Seems fine. We can do the cosmetic fixes later.

@dusansimic
Copy link
Collaborator Author

I've added the CSS styles from the issue I've mentioned. Please check if it works.

Base automatically changed from master to main January 23, 2021 08:29
@sindresorhus sindresorhus merged commit 7533c8d into sindresorhus:main Jan 25, 2021
@sindresorhus
Copy link
Owner

Nice work!

@maxoku
Copy link

maxoku commented Nov 27, 2021

Show Unread Badge isn't fixed, it was for some time, but isn't working anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants