Fix Windows icon #1455
Merged
Fix Windows icon #1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes windows icon being cut in half and bad resolution of the icon.
CvX
approved these changes
Nov 28, 2020
|
Can you either link to a electron-builder issue here in the PR comments or open one about this? |
|
Here is the electron-builder issue where if found the solution electron-userland/electron-builder#2128. It's closed due to inactivity however electron-builder still can't handle adding Windows icon properly when it's not explicitly specified. I can open a new issue regarding this if you think that's a better solution? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add fix for Windows app icon. This fixes the icon being cut in half and bad resolution of the icon. The solution for this issue was found here electron-userland/electron-builder#2128.
Closes: #1429
Closes: #1453