Manually specify sized icons for Linux .deb #1420
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know this isn't the ideal way of handling this (i.e. electron-builder should be able to automatically create the sized icons), but consider it a hard-coded workaround. This also uses the new icon (as of ff22d80).
Tested with Linux Mint 20 (Ubuntu 20.04, kernel 5.4.0-48).
To create the sized icons I used the following Bash script:
This could probably be incorporated into the build process somehow, but I'm not very familiar with npm or electron-builder.