Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually specify sized icons for Linux .deb #1420

Merged
merged 1 commit into from
Oct 18, 2020
Merged

Manually specify sized icons for Linux .deb #1420

merged 1 commit into from
Oct 18, 2020

Conversation

mquevill
Copy link
Collaborator

I know this isn't the ideal way of handling this (i.e. electron-builder should be able to automatically create the sized icons), but consider it a hard-coded workaround. This also uses the new icon (as of ff22d80).

Tested with Linux Mint 20 (Ubuntu 20.04, kernel 5.4.0-48).

To create the sized icons I used the following Bash script:

cd build/
for i in 16 32 48 64 128 256 512; do
    convert icon.png -resize ${i}x${i} icons/${i}x${i}.png
done

This could probably be incorporated into the build process somehow, but I'm not very familiar with npm or electron-builder.

@tracker1
Copy link

Would suggest adding this to the build/postbuild process... I know it's easy enough to add these manually, but would be better to keep the source impact minimal.

@sindresorhus
Copy link
Owner

The current change is fine. I don't want to complicate anything for a temporary workaround.

@sindresorhus sindresorhus merged commit a0a0ae0 into sindresorhus:master Oct 18, 2020
kolinger added a commit to kolinger/caprine that referenced this pull request Oct 20, 2020
knixeur added a commit to knixeur/dbgate that referenced this pull request Jun 10, 2021
kolinger added a commit to kolinger/caprine that referenced this pull request Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants