Automatically reset window position when disconnecting secondary screen

[tomioe]

Added a few features that I find immensely useful in my everyday use of Caprine (on Windows 10).

1. When going from multi-screen to single-screen (i.e. when undocking laptop) the main window of Caprine will sometimes be stuck off-screen (cannot even using Win+Arrow Keys to move it). Having a 'Reset Position' in the tray menu helps this problem.

2. I try to minimize my mouse movement as much as possible, but using Alt to toggle the menu and going into Exit simply isn't fast enough. I believe Command+Q is automatically bound in macOS to make an application quit, but not so on Windows, so I have added the Ctrl+Q keybinding to quit Caprine.

[tomioe]

For some reason I am getting an require-atomic-updates rule is disabled but never reported when building on source\browser.ts:581:31 and source\browser\conversation-list.ts:90:32.

[sindresorhus]

When going from multi-screen to single-screen (i.e. when undocking laptop) the main window of Caprine will sometimes be stuck off-screen (cannot even using Win+Arrow Keys to move it). Having a 'Reset Position' in the tray menu helps this problem.

I guess this is the cause: electron/electron#10862

[sindresorhus]

For some reason I am getting an require-atomic-updates rule is disabled but never reported when building on source\browser.ts:581:31 and source\browser\conversation-list.ts:90:32

That means you can just remove those disable comments.

[sindresorhus]

Can you try to do this automatically? You could listen to this event https://www.electronjs.org/docs/api/screen#event-display-removed and then reset the position. I wonder if after resetting the position, we could set the saved position again and it would be correct. Worth a shot.

[tomioe]

For some reason I am getting an require-atomic-updates rule is disabled but never reported when building on source\browser.ts:581:31 and source\browser\conversation-list.ts:90:32

That means you can just remove those disable comments.

Removing those disable comments makes my build pass locally, but fails when building in Travis. For some reason, I don't get the Possible race condition... error when building locally.

[tomioe]

Can you try to do this automatically? You could listen to this event https://www.electronjs.org/docs/api/screen#event-display-removed and then reset the position. I wonder if after resetting the position, we could set the saved position again and it would be correct. Worth a shot.

Will give this a shot, would definitely be smoother to have it happen automatically.

[tomioe]

Can you try to do this automatically? You could listen to this event https://www.electronjs.org/docs/api/screen#event-display-removed and then reset the position. I wonder if after resetting the position, we could set the saved position again and it would be correct. Worth a shot.

I've tried an implementing this in 9f6e1ad. It can be tested in Windows (if using two screens), by moving the Caprine main window to the secondary screen and setting the "Project" (Win+P) setting to "PC Screen Only". The Caprine window position should move to the same position on the primary screen as it had on the secondary screen.

[sindresorhus]

I believe Command+Q is automatically bound in macOS to make an application quit, but not so on Windows, so I have added the Ctrl+Q keybinding to quit Caprine.

Is that really a Windows convention? Do other Windows app support that. Because the menu item is named "Exit" on windows, so "Q" doesn't really make sense.

[tomioe]

I believe Command+Q is automatically bound in macOS to make an application quit, but not so on Windows, so I have added the Ctrl+Q keybinding to quit Caprine.

Is that really a Windows convention? Do other Windows app support that. Because the menu item is named "Exit" on windows, so "Q" doesn't really make sense.

Huh, I must've picked up that bad habit over the years... I just assumed it was a conventional shortcut, due to how closely it is to Cmd+Q, but I was wrong: https://support.microsoft.com/en-us/help/12445/windows-keyboard-shortcuts

Although uncommon, it is still implemented in some applications (i.e. Firefox uses Ctrl+Shift+Q), while others seem to favor the more idiomatic Alt+F, X:https://www.ghacks.net/2018/10/22/google-retires-ctrl-shift-q-in-chrome-to-exit-web-browser/

Currently Alt+F, X does not work in Carpine, since underlined letters for keyboard navigation have not been implemented. Perhaps this is a better suited goal of this PR?

And also, cheers for the review! 👍

[sindresorhus]

Currently Alt+F, X does not work in Carpine, since underlined letters for keyboard navigation have not been implemented. Perhaps this is a better suited goal of this PR?

Yes, but that's really out of the scope of this PR and should be a separate PR.

[sindresorhus]

The PR title needs to be updated.