Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to force sidebar width #1170

Merged
merged 2 commits into from
Nov 22, 2019
Merged

Add ability to force sidebar width #1170

merged 2 commits into from
Nov 22, 2019

Conversation

jaflo
Copy link
Contributor

@jaflo jaflo commented Nov 7, 2019

Adds the ability to change between different sidebar widths (fixes #297). Let's you choose between:

  • adaptive (default, changes with window size)
  • hidden (same as before, hides sidebar completely, fixed to move group text title out of the way of MacOS traffic lights)
  • narrow (force narrow-screen sidebar on all window sizes)
  • wide (force wide-screen sidebar on all window sizes)

image

I wasn't sure on how to keep the toggle sidebar keyboard shortcut, so I made the menu item to hide the sidebar act as toggle. This might be unconventional, let me know if there is a better way.

source/menu.ts Outdated Show resolved Hide resolved
source/config.ts Show resolved Hide resolved
@sindresorhus sindresorhus requested a review from CvX November 11, 2019 16:38
@jaflo
Copy link
Contributor Author

jaflo commented Nov 19, 2019

@sindresorhus @CvX is there any update on this?

@sindresorhus sindresorhus merged commit a6c914e into sindresorhus:master Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compact contact sidebar even on larger sizes
2 participants