Fix "Attach Files" keyboard shortcut #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be good to know what This suggests it's possible to override even core Electron keyboard shortcuts, but maybe electron-localshortcut is not able to? |
|
You need to update the readme too. |
`CommandOrControl+Shift+A` requires two presses before activating at my system. I'm guessing that the key combination conflicts with something. Change to `CommandOrControl+T` to make the keyboard shortcut work in one key press.
|
Thanks. Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was happy to see v2.40.0 released, with the new "Attach Files" keyboard shortcut 😄 Good work 🍻
Was eager to try "Attach Files", and it works, though not well.
CommandOrControl+Shift+Arequires two presses before activating at my system. I'm guessing that the key combination conflicts with something.I'm proposing to change it to
CommandOrControl+Tto make it work in one key press. Any other combination is fine as well, as long as it works.