Improve cropping for system emoji on some Linux systems #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was able to test that this change does not create any issues with Noto Emoji (noto-fonts-emoji in Arch). |
|
Would it be possible to get some feedback? |
|
I maybe be able to test this on Windows and Ubuntu in a couple of days, unless anyone else wants to try it out and will beat me to it. 😉 |
|
Thank you @CvX , I'm confident it should also work with Ubuntu, but if Windows doesn't cooperate we might have to pull my changes out to an |
CvX
approved these changes
Sep 3, 2019
sindresorhus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a cropping issue (emojis are rendered too far up) when using my system font, ttf-joypixels on Arch Linux. This change fixes it for me, but I'm not in a position to test if it breaks things for other systems/font packages.