Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons not included into build #754

Closed
dusansimic opened this issue Jan 30, 2019 · 1 comment
Closed

Icons not included into build #754

dusansimic opened this issue Jan 30, 2019 · 1 comment

Comments

@dusansimic
Copy link
Collaborator

Since the codebase update to TypeScript, theres been an error when running Caprine (npm start). The icons from static folder are not included into the build for some reason. The process starts but Caprine window doesn't open.

Here's the log.

(node:2974) UnhandledPromiseRejectionWarning: TypeError: Error processing argument at index 0, conversion failure from /home/dusan/dev/caprine/dist-js/static/IconTray.png
    at Object.create (/home/dusan/dev/caprine/dist-js/tray.js:42:16)
    at /home/dusan/dev/caprine/dist-js/index.js:231:20
(node:2974) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:2974) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

I've tested this just on Linux (Ubuntu 18.10 with Gnome 3.30.1).

CvX added a commit to CvX/caprine that referenced this issue Jan 30, 2019
@CvX
Copy link
Collaborator

CvX commented Jan 30, 2019

Good catch, thanks for the report! 🙂 I've pushed the fix in #755.

sindresorhus pushed a commit that referenced this issue Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants