Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use official Messenger dark mode #1459

Closed
1nikolas opened this issue Dec 8, 2020 · 10 comments
Closed

Use official Messenger dark mode #1459

1nikolas opened this issue Dec 8, 2020 · 10 comments

Comments

@1nikolas
Copy link
Collaborator

1nikolas commented Dec 8, 2020

Facebook actually has an official dark mode for Messenger. Take a look https://www.facebook.com/messages/ go there with dark mode on facebook.com. Then there is an iframe with a token (if you want to hide the facebook bar) and that iframe is messenger.com in dark mode. This even has stickers and gifs in dark mode and should be easy to implement

@dusansimic
Copy link
Collaborator

Thanks for pointing that out however Messenger is rolling out a major UI redesign which will break (and is already breaking) almost all of Caprine features. This is currently a priority for us, including fixing the current way we handle dark mode. We will look into this option in the future but in my opinion, we should wait for Messenger.com to get native dark mode instead of hacking around facebook.com/messages.

@MathPlayer
Copy link

Waiting might be in vain, messenger.com does not have dark mode for quite a lot of time now, compared to facebook.com/messages. Hopefully messenger.com will also get the facelift, yet I doubt that.
As an interesting fact, I asked some facebook employees how is their messenger.com looking, they do get the blueish dark mode as default.

@dexter93
Copy link

messenger.com at the moment is basically facebook.com/messages
While there is no button to trigger the dark mode you can easily do that by adding class "__fb-dark-mode" to the html
image

@davidgereb
Copy link

as a workaround based on @dexter93 answer, trigger dev tools with F12 and add __fb-dark-mode the class to the html

@flareglare
Copy link

If there would be a way to execute JS on startup this would apply this class automatically:
document.querySelector('html').classList.add('__fb-dark-mode')

@dusansimic
Copy link
Collaborator

@dexter93 thanks for that awesome info. That seems to work on new design only since I have the old design of messenger and it doesn't work. I'd like to ask @CvX about this. If this actually works on the new design, we could ditch our dark mode altogether and just add patches that we'd like to the both dark mode and light mode. Of corse, we'll keep custom CSS feature there.

@dexter93
Copy link

@dexter93 thanks for that awesome info. That seems to work on new design only since I have the old design of messenger and it doesn't work. I'd like to ask @CvX about this. If this actually works on the new design, we could ditch our dark mode altogether and just add patches that we'd like to the both dark mode and light mode. Of corse, we'll keep custom CSS feature there.

no probs. I got tired of eye bleeding white so I took a look deeper

you can pull my current dark mode enabled commits here and try it out
#1452 (comment)

@mzso
Copy link

mzso commented Dec 14, 2020

@dusansimic commented on 2020. dec. 8. 12:10 CET:

Thanks for pointing that out however Messenger is rolling out a major UI redesign which will break (and is already breaking) almost all of Caprine features. This is currently a priority for us, including fixing the current way we handle dark mode. We will look into this option in the future but in my opinion, we should wait for Messenger.com to get native dark mode instead of hacking around facebook.com/messages.

Seems like that's already is happening. And dark mode is broken already.

@PrimozR
Copy link

PrimozR commented Dec 23, 2020

FYI, I currently have a dark mode enabled messenger.com.

Is the features breaking problem including notifications in Caprine not working?

@dusansimic
Copy link
Collaborator

The fix is merged into master so dark mode will work on next Caprine update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants