Add remember option checkbox in private mode dialog (#1289)

Co-authored-by: Sindre Sorhus <[email protected]>
sindresorhus · Mar 9, 2020 · 9197321 · 9197321
1 parent 5daa934
commit 9197321
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 10 deletions.
diff --git a/source/config.ts b/source/config.ts
@@ -5,6 +5,7 @@ type StoreType = {
 	followSystemAppearance: boolean;
 	darkMode: boolean;
 	privateMode: boolean;
+	showPrivateModePrompt: boolean;
 	vibrancy: 'none' | 'sidebar' | 'full';
 	zoomFactor: number;
 	lastWindowState: {
@@ -53,6 +54,10 @@ const schema: {[Key in keyof StoreType]: Store.Schema} = {
 		type: 'boolean',
 		default: false
 	},
+	showPrivateModePrompt: {
+		type: 'boolean',
+		default: true
+	},
 	vibrancy: {
 		type: 'string',
 		enum: ['none', 'sidebar', 'full'],

diff --git a/source/menu.ts b/source/menu.ts
@@ -432,27 +432,32 @@ Press Command/Ctrl+R in Caprine to see your changes.
 			type: 'checkbox',
 			checked: config.get('privateMode'),
 			accelerator: 'CommandOrControl+Shift+N',
-			click(menuItem, _browserWindow, event) {
-				if (!config.get('privateMode') && event.shiftKey) {
-					const confirmPrivateMode = dialog.showMessageBoxSync({
+			async click(menuItem, _browserWindow, event) {
+				if (!config.get('privateMode') && config.get('showPrivateModePrompt') && event.shiftKey) {
+					const result = await dialog.showMessageBox(_browserWindow, {
 						message: 'Are you sure you want to hide names and avatars?',
 						detail: 'This was triggered by Command/Control+Shift+N.',
 						buttons: [
 							'Hide',
 							'Don\'t Hide'
 						],
 						defaultId: 0,
-						cancelId: 1
-					}) === 0;
+						cancelId: 1,
+						checkboxLabel: 'Don\'t ask me again'
+					});
+
+					config.set('showPrivateModePrompt', !result.checkboxChecked);
 
-					if (!confirmPrivateMode) {
+					if (result.response === 0) {
+						config.set('privateMode', !config.get('privateMode'));
+						sendAction('set-private-mode');
+					} else if (result.response === 1) {
 						menuItem.checked = false;
-						return;
 					}
+				} else {
+					config.set('privateMode', !config.get('privateMode'));
+					sendAction('set-private-mode');
 				}
-
-				config.set('privateMode', !config.get('privateMode'));
-				sendAction('set-private-mode');
 			}
 		},
 		{