Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"IDs" isn't camelized well #95

Closed
yunics-highfield opened this issue Mar 29, 2022 · 3 comments · Fixed by #102
Closed

"IDs" isn't camelized well #95

yunics-highfield opened this issue Mar 29, 2022 · 3 comments · Fixed by #102
Labels
bug help wanted

Comments

@yunics-highfield
Copy link

yunics-highfield commented Mar 29, 2022 •
edited
Loading

I'm using camelcase-keys@7.0.17.0.2. I think IDs should be ids and AmazingIDs should be amazingIds. We might need more options to decide how to camelize.

https://stackblitz.com/edit/js-d8cpct?file=index.js
@yunics-highfield yunics-highfield changed the title "IDs" doesn't camelize well. "IDs" isn't camelized well Mar 29, 2022
@sindresorhus sindresorhus transferred this issue from sindresorhus/camelcase-keys Mar 29, 2022
@sindresorhus
Copy link
Owner

I think IDs should be ids and AmazingIDs should be amazingIds.

Correct 👍

sindresorhus added a commit that referenced this issue Mar 29, 2022
@sindresorhus
Add tests for #95
e527576
@sindresorhus
Copy link
Owner

I have added some assertions for the correct behavior: e527576

@RoelRoel
Copy link

RoelRoel commented May 5, 2022

I don't agree

@ambujsahu81 ambujsahu81 mentioned this issue Nov 12, 2022
Closed
3 tasks
@ambujsahu81 ambujsahu81 mentioned this issue Dec 13, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update preserveCamelCase method ambujsahu81/camelcase
3 participants
@sindresorhus @RoelRoel @yunics-highfield