Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Corda #1683

Merged
merged 1 commit into from
Jan 21, 2020
Merged

Add Corda #1683

merged 1 commit into from
Jan 21, 2020

Conversation

akegaviar
Copy link
Contributor

@akegaviar akegaviar commented Jan 10, 2020

  • Corda - Open source blockchain platform designed for business.

This list is very useful for people working with Corda. It's the only list too, and I've had the Corda community get involved with it.

By submitting this pull request I confirm I've read and complied with the awesome list requirements 🖖

PRs reviewed: #1682, #1677, #1681, #1679. Only commented on the ones that had issues previously unreported.

- [Corda](https://github.com/chainstack/awesome-corda#readme) - Open source blockchain platform designed for business.

This list is very useful for people working with Corda. It's the only list too, and I've had the Corda community get involved with it.

By submitting this pull request I confirm I've read and complied with [the awesome list requirements](https://github.com/sindresorhus/awesome/blob/master/pull_request_template.md) 🖖
@akegaviar
Copy link
Contributor Author

unicorn

@GustavBertram
Copy link
Contributor

GustavBertram commented Jan 10, 2020

You should be able to approve PRs if they look good to you, rather that just commenting on the problems.

Copy link
Contributor

@GustavBertram GustavBertram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@aliesbelik aliesbelik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

√ Linting
Looks awesome.

@sindresorhus
Copy link
Owner

  • I don't think you should have both the text and image header. They both say the same thing. Pick one.
  • The header image should be linked to the Corda website.
  • Link Corda in Corda is an open-source blockchain platform. to its website.
  • I think the top of the readme should elaborate a little bit more on what Corda is.

@akegaviar
Copy link
Contributor Author

akegaviar commented Jan 19, 2020

I don't think you should have both the text and image header. They both say the same thing. Pick on.

Done.

The header image should be linked to the Corda website.

Done.

Link Corda in Corda is an open-source blockchain platform. to its website.

Done.

I think the top of the readme should elaborate a little bit more on what Corda is.

Done.

Copy link
Contributor

@Delta456 Delta456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Delta456 Delta456 mentioned this pull request Jan 20, 2020
@sindresorhus sindresorhus merged commit 18d0d8e into sindresorhus:master Jan 21, 2020
@sindresorhus
Copy link
Owner

DejanPerovic pushed a commit to DejanPerovic/awesome that referenced this pull request Jul 6, 2020
@aliesbelik aliesbelik mentioned this pull request Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants