-
-
Notifications
You must be signed in to change notification settings - Fork 28.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Shopware #1469
Add Shopware #1469
Conversation
Thanks for making an Awesome list! 🙌 It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome. |
@shyim you should updated short description of the repository, currently it's just |
@Xyroid thanks corrected 😊 |
Here goes my review:
|
Closing for lack of response. |
Also:
|
Shopware Awesome List
List here
Introduction
Shopware is a opensource eCommerce System written in PHP. That list contains nice extensions, themes and other examples for Shopware which i review myself.
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Yes!
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Add Name of List
(Example:Add Swift
), notUpdate readme.md
orAdd awesome list
.Example:
- [Fish](…) - User-friendly shell.
, not- [Fish](…) - Resources for Fish.
.Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Contents
, notTable of Contents
.contributing.md
. Casing is up to you.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use Travis for list linting, but the badge has no value in the readme.
Go to the top and read it again.