Add electron-redux #363
Merged
Add electron-redux #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/hardchor/electron-redux provides a way to synchronise state across processes and handle actions on both main- and renderer processes.
|
Sure, looks useful, but you should have read the contribution guidelines:
I would use that time to write some tests for it ;) |
|
Tests are already in the pipelines! It's been around for half a year, just |
|
@sindresorhus I used the time to fully cover this with tests. Mind re-opening this or would you like me to create a new PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/hardchor/electron-redux provides a way to synchronise state across windows and handle actions on both main- and renderer processes.
The issue of using redux in Electron has come up several times, e.g. in electron-react-boilerplate/electron-react-boilerplate#108 (comment)