Support RxJS 6 #23
Merged
Support RxJS 6 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update to rxjs 6 * fix import-order eslint issues existent in master * change file imports due to breaking changes of rxjs 6 Signed-off-by: mhatvan <[email protected]>
|
I’m not 100% linking will work. You can just copy-paste the directory into your project’s node_modules directory. |
|
@sindresorhus |
I honestly don't know. I don't use RxJS. |
|
The changes look good to me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22.
The PR is in draft state for now, since I didn't have the time yet to test it on an actual project.
Can I
yarn linkto test it?I had
rxjs-compatinstalled at first to make it a smooth transition and removed it again, so support for RxJS 5 is definitely dropped.Sorry for all the changes in a single commit, I kind of unexpectedly managed to get it working and passing all the tests right away :)
Looking forward to get some feedback.
IssueHunt Summary
Referenced issues
This pull request has been submitted to:
IssueHunt has been backed by the following sponsors. Become a sponsor