Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Heroku deployment guide and add PATCH #63

Merged
merged 2 commits into from
Nov 21, 2013

Conversation

kathgironpe
Copy link

fixes sinatra/sinatra-book/#62
fixes sinatra/sinatra-book/#64

@zzak
Copy link
Member

zzak commented Nov 19, 2013

Seems good to me!

@kgrz want to review and merge?

Thanks for working on this! Historically this book was a guide for users wanting to know more about using Sinatra with other libraries and building little apps. Overtime this got to be too big and we decided to create the recipes project which is more of a cookbook style format. I had plans to work on this project and make it a more detailed guide for building an app from start to finish with Sinatra but haven't had time.

You're welcome to fix it up and do whatever you'd like with it, feel free to ask any questions or submit any patches, thanks!

fixes #sinatra/sinatra-book/sinatra#62
fixes sinatra/sinatra-book/sinatra#64
@kathgironpe
Copy link
Author

@zzak Recipes are good but most people like a book or documentation format. Having no book or documentation to read feels weird for most in fact. I saw very few free resources for Sinatra and Ruby in general. Thanks for working on this. I will try to contribute as much as I can.

kgrz added a commit that referenced this pull request Nov 21, 2013
Updated Heroku deployment guide and add PATCH
@kgrz kgrz merged commit 92bb3d7 into sinatra:master Nov 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants