OpenID #149
Closed
OpenID #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed token for authManager Renamed token to accessToken for continuity Clone response to avoid calling body twice
|
Ly @netlob |
|
Ly2bb @idiidka |
|
Super nice! I totally ship you guys too. |
lieuwex
reviewed
Sep 3, 2019
jvdoorn
previously approved these changes
Sep 3, 2019
| @@ -72,13 +71,15 @@ class Http { | |||
| * @param {Object} obj | |||
| * @returns {Request} | |||
| */ | |||
| makeRequest(obj) { | |||
| async makeRequest(obj) { | |||
There was a problem hiding this comment.
Does this (the function now being async) create any issues?
There was a problem hiding this comment.
Nope, I fixed all the refrences
| const init = { | ||
| method: obj.method, | ||
| timeout: this._requestTimeout, | ||
| headers: { | ||
| ...obj.headers, | ||
| Authorization: 'Bearer ' + this._token, | ||
| Authorization: `Bearer ${accessToken}`, |
lieuwex
previously approved these changes
Sep 3, 2019
Removed token for authManager Renamed token to accessToken for continuity Clone response to avoid calling body twice
|
Okay, the login function now throws AuthErrors and the tests are updated to support that! Hopefully that`s enough for a merge ;) |
|
I love this! |
|
Great to hear all this work wasn't for nothing! :) |
lieuwex
approved these changes
Sep 3, 2019
|
Rebased on top of master with some squashes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to my magister-openid package to support proper OpenID authentication and token management.
Where you could locally store the token variable, (that would expire after an hour xd), you should now save the tokenSet. This is an object containing the access and refresh tokens. You can initialize MagisterJS with this token set, tokens are automatically checked and refreshed if necessary. This negates the saving of plaintext passwords!
My package is a wrapper around the openid-client library. It just adds support for Magister.
I think it's a lot more maintainable and clean to keep the authentication code and main library code separate. So that's why I created the package.
All tests pass on my end, and the code is linted to spec.
CREDIT TO @Sj3rd FOR HELPING ME FIGURE THIS OUT, COULDN'T HAVE DONE IT WITHOUT HIM (en z'n papa is pliesie dus deze credit moet wel)
x idiidk