"warning: global variable `$ERROR_INFO' not initialized" #400

amatsuda · 2015-07-21T09:25:52Z

This eliminates a Ruby ⚠️ when run with RUBYOPT="-w".

You can easily reproduce the warning as follows:
% ruby -w -rsimplecov -e 'SimpleCov.pid = Process.pid'

xaviershay · 2015-07-21T16:00:34Z

Where is this defined in the first place? Makes me nervous that we're papering over a bigger issue...

amatsuda · 2015-07-21T19:39:04Z

Indeed. I'm sorry that I didn't care about that...

I found that $ERROR_INFO was defined here in the stdlib English.rb as just an alias to $!.

% ruby -e '1/0 rescue p $ERROR_INFO'
nil

% ruby -rEnglish -e '1/0 rescue p $ERROR_INFO'
#<ZeroDivisionError: divided by 0>

Updated the code to check $!. I think the code looks OK with the existing comment.

xaviershay · 2015-07-23T00:16:55Z

LGTM, not sure why the build is failing :(

amatsuda · 2015-07-23T00:55:01Z

Haven't tracked down deeper yet, but aruba 0.8.x seems broken.
Bundling down aruba to 0.7.4 fixes the problem on my local environment.

bf4 · 2015-07-23T16:39:24Z

lib/simplecov/defaults.rb

@@ -47,7 +47,7 @@
  # If we are in a different process than called start, don't interfere.
  next if SimpleCov.pid != Process.pid

-  if $ERROR_INFO # was an exception thrown?
+  if $! # was an exception thrown?


Perhaps we should instead require 'English' at the top of the file?

I'm working on another app and got this failure, and it was sufficient to do

$ERROR_INFO ||= $! if $ERROR_INFO.....

This is important because it is also used below

@exit_status = $ERROR_INFO.is_a?(SystemExit) ? $ERROR_INFO.status : SimpleCov::ExitCodes::EXCEPTION

@bf4 Thank you for the hint! I wasn't aware of the other $ERROR_INFO here right after the first emergence 😲
And changing all $ERROR_INFOs to $! made the build green finally!

great, so rebase and merge?

I have a patch in my library now to add the alias :(

craiglittle · 2015-07-29T22:04:11Z

Hey there! I stopped by to offer a similar patch.

As @bf4 suggested, it seems like the better fix would be to require 'english' instead of assuming it's been done by another library, which will allow us to keep the readability of the English alias.

As @amatsuda pointed out, if we want to get the build running as soon as possible, locking aruba to the v0.7.x series will at least get the build running again, and then debugging to get on the v0.8.x series could be done as a separate step.

amatsuda · 2015-07-30T06:13:12Z

@bf4 @craiglittle Thank you for the suggestion, but to me $ERROR_INFO doesn't really add no more "readability" over # was an exception thrown?.
Requiring 'English' would add 25 global variables. I don't want to see such a "side effect" just in order to check $! value.
$! is a relatively popular one among these Perl-ish magical gvars, so I think it's fine here with the comment.

xaviershay · 2015-07-30T15:05:12Z

My two cents: $ERROR_INFO is more confusing. It's obvious that $! is a special ruby global so is populated by magic, the comment explains. $ERROR_INFO feels like it was defined by us somewhere.

craiglittle · 2015-07-30T18:16:19Z

Fair enough, works for me!

@amatsuda Were you going to get the build green by locking down to the v0.7.x series of aruba?

bf4 · 2015-07-30T19:46:25Z

I'll merge once this is green. Thanks @amatsuda ! (and everyone else commenting)

craiglittle · 2015-08-18T22:10:47Z

@amatsuda Looks like there's a different issue now, eh?

amatsuda · 2015-08-19T07:44:16Z

@craiglittle Yeah, this is weird. I cannot reproduce the failure on my local machine... 😟

bf4 · 2015-08-23T02:43:32Z

I'm working on another app and got this failure, and it was sufficient to do

$ERROR_INFO ||= $!
if $ERROR_INFO.....

This is important because it is also used below

@exit_status = $ERROR_INFO.is_a?(SystemExit) ? $ERROR_INFO.status : SimpleCov::ExitCodes::EXCEPTION

Would that make people happy?

"$ERROR_INFO is more confusing. It's obvious that $! is a special ruby global so is populated by magic, the comment explains. $ERROR_INFO feels like it was defined by us somewhere." #400 (comment)

"warning: global variable `$ERROR_INFO' not initialized"

bf4 · 2015-08-27T06:33:11Z

Alright! Let's update the CHANGELOG and we can release 0.10.1!

craiglittle · 2015-09-11T06:18:17Z

We're so close to the finish line. Looking forward to getting this warning out of my build!

kdawgwilk · 2015-09-30T19:49:52Z

👍 to see this released!

bf4 · 2015-09-30T21:28:59Z

Would someone mind helping update the CHANGELOG? I am elsewhere

@ptashman

0.11.0 2015-11-29 ([changes](simplecov-ruby/simplecov@v0.10.0...v0.10.11)) ================= ## Enhancements * Added `SimpleCov.minimum_coverage_by_file` for per-file coverage thresholds. See [#392](simplecov-ruby/simplecov#392) (thanks @ptashman) * Added `track_files` configuration option to specify a glob to always include in coverage results, whether or not those files are required. See [#422](simplecov-ruby/simplecov#422) (thanks @hugopeixoto) * Speed up `root_filter` by an order of magnitude. See [#396](simplecov-ruby/simplecov#396) (thanks @raszi) ## Bugfixes * Fix warning about global variable `$ERROR_INFO`. See [#400](simplecov-ruby/simplecov#400) (thanks @amatsuda) * Actually recurse upward looking for `.simplecov`, as claimed by the documentation, rather than only the working directory. See [#423](simplecov-ruby/simplecov#423) (thanks @alexdowad)

"$ERROR_INFO is more confusing. It's obvious that $! is a special ruby global so is populated by magic, the comment explains. $ERROR_INFO feels like it was defined by us somewhere." simplecov-ruby#400 (comment)

ShamoX · 2018-05-14T16:17:20Z

Hi,

I'm having back this warning :

$ bundle exec rspec
....
Randomized with seed 8732

*****/vendor/bundle/ruby/2.5.0/gems/simplecov-0.16.1/lib/simplecov.rb:177: warning: global variable `$ERROR_INFO' not initialized
Coverage report generated for RSpec ******

It seems that the English library doesn't declare it (I guess I'm wrong, but: https://github.com/rubyworks/english/search?utf8=✓&q=%24ERROR_INFO&type=).

I happens to me since I've included dry-validation-matcher.
But I checked in a clean environment:

$ bundle exec pry
[1] pry(main)> require 'english'
=> true
[2] pry(main)> defined? $ERROR_INFO
=> nil
[3] pry(main)> defined? $!
=> "global-variable"
[4] pry(main)>

Fix proposal

lib/simplecov.rb:177
@exit_exception = defined?($ERROR_INFO) ? $ERROR_INFO : $!

bf4 · 2018-05-15T00:06:32Z

@ShamoX This was fixed nearly three years ago. Either you're on an old version or this is a new issue. 'English' is part of the Ruby standard library.

bf4 reviewed Jul 23, 2015
View reviewed changes

amatsuda mentioned this pull request Aug 17, 2015

Avoid bundling aruba 0.8.x for now #407

Merged

amatsuda added 2 commits August 25, 2015 17:27

"warning: global variable `$ERROR_INFO' not initialized"

a61649f

Nothing wrong with $! here

8e598ac

"$ERROR_INFO is more confusing. It's obvious that $! is a special ruby global so is populated by magic, the comment explains. $ERROR_INFO feels like it was defined by us somewhere." #400 (comment)

amatsuda added a commit that referenced this pull request Aug 27, 2015

Merge pull request #400 from amatsuda/warning

0d85bd0

"warning: global variable `$ERROR_INFO' not initialized"

amatsuda merged commit 0d85bd0 into simplecov-ruby:master Aug 27, 2015

amatsuda deleted the warning branch August 27, 2015 06:18

simplecov-ruby locked as resolved and limited conversation to collaborators May 15, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

"warning: global variable `$ERROR_INFO' not initialized" #400

"warning: global variable `$ERROR_INFO' not initialized" #400

amatsuda commented Jul 21, 2015

xaviershay commented Jul 21, 2015

amatsuda commented Jul 21, 2015

xaviershay commented Jul 23, 2015

amatsuda commented Jul 23, 2015

bf4 Jul 23, 2015

bf4 Aug 21, 2015

amatsuda Aug 25, 2015

bf4 Aug 27, 2015

craiglittle commented Jul 29, 2015

amatsuda commented Jul 30, 2015

xaviershay commented Jul 30, 2015

craiglittle commented Jul 30, 2015

bf4 commented Jul 30, 2015

craiglittle commented Aug 18, 2015

amatsuda commented Aug 19, 2015

bf4 commented Aug 23, 2015

bf4 commented Aug 27, 2015

craiglittle commented Sep 11, 2015

kdawgwilk commented Sep 30, 2015

bf4 commented Sep 30, 2015

ShamoX commented May 14, 2018

bf4 commented May 15, 2018

"warning: global variable `$ERROR_INFO' not initialized" #400

"warning: global variable `$ERROR_INFO' not initialized" #400

Conversation

amatsuda commented Jul 21, 2015

xaviershay commented Jul 21, 2015

amatsuda commented Jul 21, 2015

xaviershay commented Jul 23, 2015

amatsuda commented Jul 23, 2015

bf4 Jul 23, 2015

Choose a reason for hiding this comment

bf4 Aug 21, 2015

Choose a reason for hiding this comment

amatsuda Aug 25, 2015

Choose a reason for hiding this comment

bf4 Aug 27, 2015

Choose a reason for hiding this comment

craiglittle commented Jul 29, 2015

amatsuda commented Jul 30, 2015

xaviershay commented Jul 30, 2015

craiglittle commented Jul 30, 2015

bf4 commented Jul 30, 2015

craiglittle commented Aug 18, 2015

amatsuda commented Aug 19, 2015

bf4 commented Aug 23, 2015

bf4 commented Aug 27, 2015

craiglittle commented Sep 11, 2015

kdawgwilk commented Sep 30, 2015

bf4 commented Sep 30, 2015

ShamoX commented May 14, 2018

Fix proposal

bf4 commented May 15, 2018