Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging two resultsets marks uncovered line as irrelevant #517

Closed
michelgrootjans opened this issue Aug 18, 2016 · 1 comment
Closed

Merging two resultsets marks uncovered line as irrelevant #517

michelgrootjans opened this issue Aug 18, 2016 · 1 comment

Comments

@michelgrootjans
Copy link

When merging:

...
"/app/behaviour/audit_builder.rb": [null, null, 0, null, null ],
...

and a file without a reference to /app/behaviour/audit_builder.rb

the result will be:

/coverage/merge/.resultset.json
...
"/app/behaviour/audit_builder.rb": [null, null, null, null, null ],
...

I expect this to be:

/coverage/merge/.resultset.json
...
"/app/behaviour/audit_builder.rb": [null, null, 0, null, null ],
...

I'm fixing this in https://github.com/michelgrootjans/simplecov
@michelgrootjans michelgrootjans changed the title Merging two resultsets where only one has a specific file with a not covered Merging two resultsets marks uncovered line as irrelevant Aug 18, 2016
michelgrootjans pushed a commit to michelgrootjans/simplecov that referenced this issue Aug 18, 2016
Fix for: Merging two resultsets marks uncovered line as irrelevant
0cee361 
Fixes issue simplecov-ruby#517
@michelgrootjans michelgrootjans mentioned this issue Aug 18, 2016
Closed
@PragTob
Copy link
Collaborator

PragTob commented Jan 27, 2017

Fixed 💪

@PragTob PragTob closed this as completed Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michelgrootjans @PragTob