Prematurely dropped Ruby 1.8 compatibility

[mislav]

Dir.home added in 34696d4 is not compatible with Ruby 1.8, which makes requiring simplecov in tests fail even though we were promised that no-op compatibility with 1.8 will be kept until 1.0.0:

Starting with SimpleCov 1.0.0, even no-op compatibility with Ruby <= 1.8 will be entirely dropped.

[sferik]

I don’t have gem push access.

@colszowka Can you please push a patch release to resolve this issue?

[bf4]

@sferik What's your rubygems.org email? I'll add you

[bf4]

n/m for some reason I thought I had gem push. Anyhoo, a simple gem owner t gave me the answer, so gem owner simplecov -a $(gem owner t | tail -1 | cut -d' ' -f2) would work

[colszowka]

@bf4 @sferik Sorry guys, must have forgotten that. Added you as owners on rubygems, updated the Changelog and will ship 0.9.1 within the next minutes.

[colszowka]

@xaviershay Please give me your e-mail address on rubygems so I can add you as an owner as well :)

[mislav]

On Sun, Sep 21, 2014 at 9:52 AM, Benjamin Fleischer <
[email protected]> wrote:

SimpleCov depends on the Coverage module in 1.9+, how was it ever used in
1.8? Was this documented somewhere and I missed it?

SimpleCov does not work on 1.8, however it prints out a warning on stderr
about this and doesn't crash the process. This PR is about fixing SimpleCov
to not crash the test suite if used on 1.8.

[xaviershay]

pretty sure it's notreal at rhnh dot net

[colszowka]

@bf4 At the time I initially wrote SimpleCov, Ruby 1.8 was still widely used for many projects, and especially considering the use of simplecov for gems and other libraries that should work across ruby versions, it made sense to avoid simplecov failing entirely on 1.8, instead printing a warning and bailing. You can still see that in the start method. For 1.0 I want to remove that though, since nowadays 1.8 is becoming very outdated.

@xaviershay Added you!