Merge pull request #14 from ebeigarts/fix-group-ids

Do not strip digits, hyphens and underscores in group name ids
simplecov-ruby · Oct 10, 2012 · 0a1876a · 0a1876a
2 parents 6ee67b5 + 53b8a3f
commit 0a1876a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/lib/simplecov-html.rb b/lib/simplecov-html.rb
@@ -54,6 +54,7 @@ def formatted_source_file(source_file)
 
   # Returns a table containing the given source files
   def formatted_file_list(title, source_files)
+    title_id = title.gsub(/^[^a-zA-Z]+/, '').gsub(/[^a-zA-Z0-9\-\_]/, '')
     template('file_list').result(binding)
   end
 

diff --git a/views/file_list.erb b/views/file_list.erb
@@ -1,4 +1,4 @@
-<div class="file_list_container" id="<%= title.gsub(/[^a-zA-Z]/, '') %>">
+<div class="file_list_container" id="<%= title_id %>">
   <h2>
     <span class="group_name"><%= title %></span>
     (<span class="covered_percent"><span class="<%= coverage_css_class(source_files.covered_percent) %>"><%= source_files.covered_percent.round(2) %>%</span></span>
@@ -9,7 +9,7 @@
        </span>
     </span> hits/line)
   </h2>
-  <a name="<%= title.gsub(/[^a-zA-Z]/, '') %>"></a>
+  <a name="<%= title_id %>"></a>
   <div>
     <b><%= source_files.length %></b> files in total.
     <b><%= source_files.lines_of_code %></b> relevant lines.