Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

简化ContentTrimEventInterceptorFactory.create的实现 #995

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

LightQuanta
Copy link
Contributor

有DSL Builder为什么不用

@ForliyScarlet
Copy link
Member

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@ForteScarlet ForteScarlet added the 优化 优化 label Dec 28, 2024
Copy link
Member

@ForteScarlet ForteScarlet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

最初的目的是因为直接使用实现类可以避免一些额外的对象创建,比如一个Lambda一个Builder和其中的衍生对象。
不过...都是一次性的中间产物,倒是都无伤大雅。
合理的改动,可以接受,感谢贡献~

@ForteScarlet ForteScarlet merged commit d3e1f0e into simple-robot:v4-dev Dec 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
优化 优化
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants