Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure custom tree is still memoized #322

Merged
merged 1 commit into from
Apr 6, 2019
Merged

ensure custom tree is still memoized #322

merged 1 commit into from
Apr 6, 2019

Conversation

stefanpenner
Copy link
Contributor

@stefanpenner stefanpenner commented Feb 21, 2019 •
edited
Loading

Without this, each add-on which includes this add-on will rebuild the tree.

@Turbo87
Copy link
Collaborator

Turbo87 commented Feb 21, 2019

I'm not sure I understand this PR. is there some documentation available on cacheKeyForTree()?

@stefanpenner
Copy link
Contributor Author

Unfortunately I don’t think the original authors wrote any docs. I’m not sure when I’ll have time to backfill them, but will try to find time.

@snewcomer
Copy link

@Turbo87 Here is something - https://github.com/ember-cli/rfcs/blob/master/complete/0090-addon-tree-caching.md

@snewcomer
Copy link

And the relevant PR - ember-cli/ember-cli#6573

@stefanpenner
Copy link
Contributor Author

cc @Turbo87

@Turbo87 Turbo87 force-pushed the memoize-custom-tree branch from d17656d to bfbf116 Compare April 6, 2019 09:11
@Turbo87 Turbo87 merged commit 449706c into mainmatter:master Apr 6, 2019
@stefanpenner stefanpenner deleted the memoize-custom-tree branch April 6, 2019 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefanpenner @Turbo87 @snewcomer