Merge pull request #322 from stefanpenner/memoize-custom-tree

ensure custom tree is still memoized
mainmatter · Apr 6, 2019 · 449706c · 449706c
2 parents d287531 + bfbf116
commit 449706c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/index.js b/index.js
@@ -3,6 +3,7 @@
 /* eslint-env node */
 
 const VersionChecker = require('ember-cli-version-checker');
+const cacheKeyForTree = require('calculate-cache-key-for-tree');
 
 module.exports = {
   name: 'ember-test-selectors',
@@ -74,6 +75,15 @@ module.exports = {
     }
   },
 
+  cacheKeyForTree(treeType) {
+    // ensure our treeForAddon is memoized
+    if (treeType === 'addon') {
+      return cacheKeyForTree('addon', this, [this._stripTestSelectors]);
+    } else {
+      return cacheKeyForTree(treeType, this);
+    }
+  },
+
   treeForAddon() {
     // remove our "addon" folder from the build if we're stripping test selectors
     if (!this._stripTestSelectors) {

diff --git a/package.json b/package.json
@@ -25,6 +25,7 @@
     "test:strip": "STRIP_TEST_SELECTORS=true ember test"
   },
   "dependencies": {
+    "calculate-cache-key-for-tree": "^1.1.0",
     "ember-cli-babel": "^6.8.2",
     "ember-cli-version-checker": "^3.1.3"
   },